Hello @zhxt, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Thank you for the PR! I haven't had a chance to look at the schematics yet but can some of these be added to the devicetree? I understand some --but hopefully not all-- of these peripherals are powered through the unsupported (yet!) AXP2101 PMIC's regulators, but it might still make sense to already describe them in the DT.

Yeah, I will try to add some other peripherals to the DT (and will also try to make them work if I can) . A friend of mime will take a look at AXP2101 regulator & AW9532B LED/GPIO controller(also unsupported yet) driver support later days once he has time.

I am also working on supporting CoreS3 with #79765 based on this.
There are some areas that need improvement, so please consider fixing them.

I am also working on supporting CoreS3 with #79765 based on this.

There are some areas that need improvement, so please consider fixing them.

@soburi I had got backlight working， but display still need some work to be done.

I am also working on supporting CoreS3 with #79765 based on this.
There are some areas that need improvement, so please consider fixing them.

@soburi I had got backlight working， but display still need some work to be done.

In Zephyr, when committing to minimal support, it is often submitted with Hello World and blinky working, that is, GPIO and UART working. My PR #79765 and #78098 are also related, so it's better to proceed with the already finished part.

I am also working on supporting CoreS3 with #79765 based on this.
There are some areas that need improvement, so please consider fixing them.

@soburi I had got backlight working， but display still need some work to be done.

In Zephyr, when committing to minimal support, it is often submitted with Hello World and blinky working, that is, GPIO and UART working. My PR #79765 and #78098 are also related, so it's better to proceed with the already finished part.

Yes, agree. The very first commit has hello world working. (but blinky seems rely on the external GPIO controller-aw9523b, there is also a test/wip version implementation https://github.com/zhxt/zephyr/tree/main-gpio-aw9523b),

It's very busy on daily work recently, haven't got much time working on this porting, -_-

I am also working on supporting CoreS3 with #79765 based on this.
There are some areas that need improvement, so please consider fixing them.

@soburi I had got backlight working， but display still need some work to be done.

In Zephyr, when committing to minimal support, it is often submitted with Hello World and blinky working, that is, GPIO and UART working. My PR #79765 and #78098 are also related, so it's better to proceed with the already finished part.

Yes, agree. The very first commit has hello world working. (but blinky seems rely on the external GPIO controller-aw9523b, there is also a test/wip version implementation https://github.com/zhxt/zephyr/tree/main-gpio-aw9523b),

It's very busy on daily work recently, haven't got much time working on this porting, -_-

My PR #79765 contains AXP2101 LED contrl feature support.
So, I think the request to run blinky sample can be aside temporary.
(It not run the real blinky sample, but the same functionality work.)
I think it is good to finish this PR with minimam functionality.

I am also working on supporting CoreS3 with #79765 based on this.
There are some areas that need improvement, so please consider fixing them.

@soburi I had got backlight working， but display still need some work to be done.

In Zephyr, when committing to minimal support, it is often submitted with Hello World and blinky working, that is, GPIO and UART working. My PR #79765 and #78098 are also related, so it's better to proceed with the already finished part.

Yes, agree. The very first commit has hello world working. (but blinky seems rely on the external GPIO controller-aw9523b, there is also a test/wip version implementation https://github.com/zhxt/zephyr/tree/main-gpio-aw9523b),
It's very busy on daily work recently, haven't got much time working on this porting, -_-

My PR #79765 contains AXP2101 LED contrl feature support. So, I think the request to run blinky sample can be aside temporary. (It not run the real blinky sample, but the same functionality work.) I think it is good to finish this PR with minimam functionality.

Yeah, will try to get more time to finish a minimal version.

@nordicjm Could you please take a look?

minor nit, also my line can be removed from signed off by

Removed.

Hi @zhxt!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁